[PATCH] D33007: [scudo] Use our own combined allocator

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 14:36:05 PDT 2017


alekseyshl added inline comments.


================
Comment at: lib/scudo/scudo_allocator.cpp:367
+    uptr AlignedSize = (Alignment > MinAlignment) ?
+        NeededSize + (Alignment - AlignedChunkHeaderSize): NeededSize;
+    if (AlignedSize >= MaxAllowedMallocSize)
----------------
Add space before ":"


================
Comment at: lib/scudo/scudo_allocator_combined.h:147
+  void ForEachChunk(ForEachChunkCallback Callback, void *Arg) {
+    UNIMPLEMENTED();
+  }
----------------
Are those UNIMPLEMENTED going to be implemented at some point?


https://reviews.llvm.org/D33007





More information about the llvm-commits mailing list