[PATCH] D32987: DWARF: When parsing type unit headers take the length field into account.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: test/DebugInfo/Inputs/typeunit-header.s:11-12
+# Real type unit dies have quite different attributes of course, but we
+# just need to demonstrate an issue with validating length, so we just give it
+# a single visibility attribute.
+        .section .debug_abbrev,"", at progbits
----------------
wolfgangp wrote:
> dblaikie wrote:
> > Do you need to give it any attributes at all?
> Technically no, but I thought it would lend a little more substance to the test.
I'd probably skip it entirely - otherwise it leads to the question "why exactly one? is there some special/interesting case there?" which may make it harder to modify the test in the future for fear that the reader is missing something important.


https://reviews.llvm.org/D32987