[PATCH] D32987: DWARF: When parsing type unit headers take the length field into account.

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 10:20:46 PDT 2017


wolfgangp added inline comments.


================
Comment at: test/DebugInfo/Inputs/typeunit-header.s:11-12
+# Real type unit dies have quite different attributes of course, but we
+# just need to demonstrate an issue with validating length, so we just give it
+# a single visibility attribute.
+        .section .debug_abbrev,"", at progbits
----------------
dblaikie wrote:
> Do you need to give it any attributes at all?
Technically no, but I thought it would lend a little more substance to the test.


https://reviews.llvm.org/D32987





More information about the llvm-commits mailing list