[PATCH] D30086: Add generic IR vector reductions

[Elena Demikhovsky via Phabricator via llvm-commits]

delena added a comment.

A minor comment, the code looks good to me.



================
Comment at: lib/Transforms/Utils/LoopUtils.cpp:1159
+    else
+      TmpVec = RecurrenceDescriptor::createMinMaxOp(Builder, MinMaxKind, TmpVec,
+                                                    Shuf);
----------------
MinMaxKind should not be invalid in this case. I suggest to add assert() here.


Repository:
  rL LLVM

https://reviews.llvm.org/D30086