[PATCH] D30086: Add generic IR vector reductions

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

In https://reviews.llvm.org/D30086#748613, @rengolin wrote:

> In https://reviews.llvm.org/D30086#748611, @aemerson wrote:
>
> > When people add new intrinsics they don't really add tests to check the IR since you get assertion failures during the FunctionType creation if something goes wrong.
>
>
> But without IR functions that actually uses them, there's no way to get the assertion, right?


If you have a look at prior art for adding intrinsics you'll see that actual verifier tests are only done for illegal combinations of constant value parameters. There are no illegal constant parameter combinations with this patch. E.g. Dan Berlin's r294341 doesn't come with a test, likewise with others.


Repository:
  rL LLVM

https://reviews.llvm.org/D30086