[lld] r302227 - [ELF] - Accept --defsym foo=value form.

[Rui Ueyama via llvm-commits]

Please follow the convention -- if you have two options, -foo= and -foo,
one is named as foo_eq in this file. Please send me a patch review. Thanks.

On Fri, May 5, 2017 at 4:59 AM, George Rimar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: grimar
> Date: Fri May  5 06:59:15 2017
> New Revision: 302227
>
> URL: http://llvm.org/viewvc/llvm-project?rev=302227&view=rev
> Log:
> [ELF] - Accept --defsym foo=value form.
>
> Previously we accepted --defsym=foo=value only.
>
> Reported by Sean Silva.
>
> Modified:
>     lld/trunk/ELF/Options.td
>     lld/trunk/test/ELF/defsym.s
>
> Modified: lld/trunk/ELF/Options.td
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td
> ?rev=302227&r1=302226&r2=302227&view=diff
> ============================================================
> ==================
> --- lld/trunk/ELF/Options.td (original)
> +++ lld/trunk/ELF/Options.td Fri May  5 06:59:15 2017
> @@ -290,6 +290,7 @@ def alias_L__library_path: J<"library-pa
>  def alias_define_common_d: Flag<["-"], "d">, Alias<define_common>;
>  def alias_define_common_dc: F<"dc">, Alias<define_common>;
>  def alias_define_common_dp: F<"dp">, Alias<define_common>;
> +def alias_defsym: S<"defsym">, Alias<defsym>;
>  def alias_discard_all_x: Flag<["-"], "x">, Alias<discard_all>;
>  def alias_discard_locals_X: Flag<["-"], "X">, Alias<discard_locals>;
>  def alias_dynamic_list: J<"dynamic-list=">, Alias<dynamic_list>;
>
> Modified: lld/trunk/test/ELF/defsym.s
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/defsy
> m.s?rev=302227&r1=302226&r2=302227&view=diff
> ============================================================
> ==================
> --- lld/trunk/test/ELF/defsym.s (original)
> +++ lld/trunk/test/ELF/defsym.s Fri May  5 06:59:15 2017
> @@ -4,6 +4,11 @@
>  # RUN: llvm-readobj -t -s %t | FileCheck %s
>  # RUN: llvm-objdump -d -print-imm-hex %t | FileCheck %s --check-prefix=USE
>
> +## Check that we accept --defsym foo2=foo1 form.
> +# RUN: ld.lld -o %t2 %t.o --defsym foo2=foo1
> +# RUN: llvm-readobj -t -s %t2 | FileCheck %s
> +# RUN: llvm-objdump -d -print-imm-hex %t2 | FileCheck %s
> --check-prefix=USE
> +
>  ## In compare with GNU linkers, symbol defined with --defsym does
>  ## not get aliased name in symbol table:
>  # CHECK:      Symbol {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170505/12a15423/attachment.html>