<div dir="ltr">Please follow the convention -- if you have two options, -foo= and -foo, one is named as foo_eq in this file. Please send me a patch review. Thanks.<div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 5, 2017 at 4:59 AM, George Rimar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grimar<br>
Date: Fri May  5 06:59:15 2017<br>
New Revision: 302227<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=302227&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=302227&view=rev</a><br>
Log:<br>
[ELF] - Accept --defsym foo=value form.<br>
<br>
Previously we accepted --defsym=foo=value only.<br>
<br>
Reported by Sean Silva.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Options.td<br>
    lld/trunk/test/ELF/defsym.s<br>
<br>
Modified: lld/trunk/ELF/Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=302227&r1=302226&r2=302227&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/lld/trunk/ELF/Options.td<wbr>?rev=302227&r1=302226&r2=30222<wbr>7&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/Options.td (original)<br>
+++ lld/trunk/ELF/Options.td Fri May  5 06:59:15 2017<br>
@@ -290,6 +290,7 @@ def alias_L__library_path: J<"library-pa<br>
 def alias_define_common_d: Flag<["-"], "d">, Alias<define_common>;<br>
 def alias_define_common_dc: F<"dc">, Alias<define_common>;<br>
 def alias_define_common_dp: F<"dp">, Alias<define_common>;<br>
+def alias_defsym: S<"defsym">, Alias<defsym>;<br>
 def alias_discard_all_x: Flag<["-"], "x">, Alias<discard_all>;<br>
 def alias_discard_locals_X: Flag<["-"], "X">, Alias<discard_locals>;<br>
 def alias_dynamic_list: J<"dynamic-list=">, Alias<dynamic_list>;<br>
<br>
Modified: lld/trunk/test/ELF/defsym.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/defsym.s?rev=302227&r1=302226&r2=302227&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/lld/trunk/test/ELF/defsy<wbr>m.s?rev=302227&r1=302226&r2=<wbr>302227&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/test/ELF/defsym.s (original)<br>
+++ lld/trunk/test/ELF/defsym.s Fri May  5 06:59:15 2017<br>
@@ -4,6 +4,11 @@<br>
 # RUN: llvm-readobj -t -s %t | FileCheck %s<br>
 # RUN: llvm-objdump -d -print-imm-hex %t | FileCheck %s --check-prefix=USE<br>
<br>
+## Check that we accept --defsym foo2=foo1 form.<br>
+# RUN: ld.lld -o %t2 %t.o --defsym foo2=foo1<br>
+# RUN: llvm-readobj -t -s %t2 | FileCheck %s<br>
+# RUN: llvm-objdump -d -print-imm-hex %t2 | FileCheck %s --check-prefix=USE<br>
+<br>
 ## In compare with GNU linkers, symbol defined with --defsym does<br>
 ## not get aliased name in symbol table:<br>
 # CHECK:      Symbol {<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>