[PATCH] D32780: [AArch64] Make the TargetParser add CPU exts provided by the arch.

[Ahmed Bougacha via Phabricator via llvm-commits]

ab added a comment.

Thanks Renato!



================
Comment at: unittests/Support/TargetParserTest.cpp:614
       "invalid", "invalid", "invalid",
-      AArch64::AEK_INVALID, ""));
+      AArch64::AEK_NONE, ""));
   EXPECT_TRUE(testAArch64CPU(
----------------
rengolin wrote:
> I wonder what's the use of AEK_INVALID...
It's useful as a return value for completely unknown CPUs, no?  'invalid' is listed in the .def, so we only get AEK_NONE for that.  I considered adding a test for a "foobar" CPU, and that should provide AEK_INVALID, but that doesn't seem like a very valuable test, so, eh!


Repository:
  rL LLVM

https://reviews.llvm.org/D32780