[PATCH] D32498: [CodeView] omit forward references for unnamed structs and unions

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 18:29:56 PDT 2017


rnk added a comment.

Isn't this problematic if the unnamed struct has methods? That's the usual way you get cycles in the type graph.

If this only applies to plain C structs, I would rather start inventing "unique" names by hashing the source location in some way and then continuing to emit forward decls. That solves problems with named types in anonymous namespaces, which we currently don't give unique names.


https://reviews.llvm.org/D32498





More information about the llvm-commits mailing list