[PATCH] D32739: [Polly] JSONImporter misses checks whether the data it imports makes sense.

[Andreas Simbuerger via Phabricator via llvm-commits]

simbuerg added inline comments.


================
Comment at: lib/Exchange/JSONExporter.cpp:382
 
+  // Check wether the new schedule is valid or not.
   if (!D.isValidSchedule(S, &NewSchedule)) {
----------------
'whether'


================
Comment at: lib/Exchange/JSONExporter.cpp:640
+    if (!Arrays[ArrayIdx].isMember("sizes")) {
+      errs() << "Array at index " << ArrayIdx << " has not key 'sizes'.\n";
+      return false;
----------------
has no key


================
Comment at: lib/Exchange/JSONExporter.cpp:649
+    if (!Arrays[ArrayIdx].isMember("name")) {
+      errs() << "Array at index " << ArrayIdx << " has not key 'name'.\n";
+      return false;
----------------
has no key


https://reviews.llvm.org/D32739