[PATCH] D32739: [Polly] JSONImporter misses checks whether the data it imports makes sense.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Thank you for the patch, it looks very promising.

When uploading patches, please use also add context (with git: `git diff -U999999`, see: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)



================
Comment at: test/CMakeLists.txt:9
+  "vect"
+  "JSONExporter")
 
----------------
Mmmh, that list looks very outdated. It is also only used to make `polly-test-${dir}` targets and only in out-of-LLVM-source builds. I think we should remove it (I'll do this in a separate commit)


================
Comment at: test/JSONExporter/rlr2.ll:2
+; RUN: (2>&1 opt %loadPolly -polly-import-jscop-dir=%S -polly-import-jscop -polly-ast -polly-ast-detect-parallel -analyze < %s) | FileCheck %s 
+; RUN: (2>&1 opt %loadPolly -polyhedral-info -polly-check-parallel -analyze < %s) | FileCheck %s -check-prefix=PINFO 
+;
----------------
I don't think the `-analyze` output is interesting for these test cases.


https://reviews.llvm.org/D32739