[PATCH] D32394: Add extra operand to CALLSEQ_START to keep frame part set up previously

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 09:38:47 PDT 2017


sepavloff marked 2 inline comments as done.
sepavloff added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAG.h:728
   /// (to ensure it's not CSE'd).  CALLSEQ_START does not have a useful SDLoc.
   SDValue getCALLSEQ_START(SDValue Chain, SDValue Op, const SDLoc &DL) {
     SDVTList VTs = getVTList(MVT::Other, MVT::Glue);
----------------
RKSimon wrote:
> Can this be removed/deprecated?
Removed it.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:5088
+  int64_t FrameSize = cast<ConstantSDNode>(
+                          CallSeqStart.getNode()->getOperand(1))->getSExtValue();
+  SDValue NewCallSeqStart = DAG.getCALLSEQ_START(MemcpyCall, FrameSize, 0,
----------------
RKSimon wrote:
> getConstantOperand() ?
Indeed, thank you.


https://reviews.llvm.org/D32394





More information about the llvm-commits mailing list