[PATCH] D32652: Gracefully handle empty .drectve sections
Dave Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 1 22:45:12 PDT 2017
kastiglione added a comment.
> please wait until tomorrow
I don't have commit access anyway :)
================
Comment at: test/Object/Inputs/COFF/empty-drectve.yaml:1-14
+--- !COFF
+header:
+ Machine: IMAGE_FILE_MACHINE_I386
+sections:
+ - Name: .drectve
+ Characteristics: [ IMAGE_SCN_LNK_INFO, IMAGE_SCN_LNK_REMOVE ]
+ SectionData: ''
----------------
ruiu wrote:
> You can merge this file with coff-empty-drectve.test file.
I was going to write the test this way originally, but the handful of tests I looked at in `test/Object` mostly all used a separate input file, it seemed like this was the convention. I'm happy to merge these two files.
https://reviews.llvm.org/D32652
More information about the llvm-commits
mailing list