[PATCH] D32652: Gracefully handle empty .drectve sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM, but please wait until tomorrow to give other people a chance to take a look.



================
Comment at: test/Object/Inputs/COFF/empty-drectve.yaml:1-14
+--- !COFF
+header:
+  Machine:           IMAGE_FILE_MACHINE_I386
+sections:
+  - Name:            .drectve
+    Characteristics: [ IMAGE_SCN_LNK_INFO, IMAGE_SCN_LNK_REMOVE ]
+    SectionData:     ''
----------------
You can merge this file with coff-empty-drectve.test file.


================
Comment at: test/Object/coff-empty-drectve.test:1
+RUN: yaml2obj %p/Inputs/COFF/empty-drectve.yaml | llvm-readobj -coff-directives - | FileCheck %s
+
----------------
To do that you want to change this to

  yaml2obj %s | llvm-readobj ...


================
Comment at: test/Object/coff-empty-drectve.test:3
+
+CHECK: Directive(s): {{$}}
----------------
And make this line a YAML comment.


https://reviews.llvm.org/D32652