[lld] r301896 - Update commetns.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Mon May 1 19:58:05 PDT 2017
Author: ruiu
Date: Mon May 1 21:58:04 2017
New Revision: 301896
URL: http://llvm.org/viewvc/llvm-project?rev=301896&view=rev
Log:
Update commetns.
Modified:
lld/trunk/ELF/InputFiles.cpp
Modified: lld/trunk/ELF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=301896&r1=301895&r2=301896&view=diff
==============================================================================
--- lld/trunk/ELF/InputFiles.cpp (original)
+++ lld/trunk/ELF/InputFiles.cpp Mon May 1 21:58:04 2017
@@ -410,9 +410,11 @@ elf::ObjectFile<ELFT>::createInputSectio
// Mergeable sections with relocations are tricky because relocations
// need to be taken into account when comparing section contents for
- // merging. The MergeInputSection class currently doesn't care about
- // relocations, and it's unlikely to support it in future because such
- // sections are rare. We simply handle such sections as non-mergeable.
+ // merging. It doesn't worth supporting such mergeable sections because
+ // they are rare and it'd complicates the internal design (we usually
+ // have to determine if two sections are mergeable early in the link
+ // process much before applying relocations). We simply handle mergeable
+ // sections with relocations as non-mergeable.
if (auto *MS = dyn_cast<MergeInputSection>(Target)) {
Target = toRegularSection(MS);
this->Sections[Sec.sh_info] = Target;
More information about the llvm-commits
mailing list