[lld] r301895 - Make getArchiveMembers function a non-member function.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 19:57:45 PDT 2017


Author: ruiu
Date: Mon May  1 21:57:45 2017
New Revision: 301895

URL: http://llvm.org/viewvc/llvm-project?rev=301895&view=rev
Log:
Make getArchiveMembers function a non-member function.

It didn't have to be a member function of Driver. This patch makes
that function a file-scoped non-member function.

Modified:
    lld/trunk/ELF/Driver.cpp
    lld/trunk/ELF/Driver.h

Modified: lld/trunk/ELF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=301895&r1=301894&r2=301895&view=diff
==============================================================================
--- lld/trunk/ELF/Driver.cpp (original)
+++ lld/trunk/ELF/Driver.cpp Mon May  1 21:57:45 2017
@@ -124,7 +124,7 @@ static std::tuple<ELFKind, uint16_t, uin
 // Returns slices of MB by parsing MB as an archive file.
 // Each slice consists of a member file in the archive.
 std::vector<MemoryBufferRef>
-LinkerDriver::getArchiveMembers(MemoryBufferRef MB) {
+static getArchiveMembers(MemoryBufferRef MB) {
   std::unique_ptr<Archive> File =
       check(Archive::create(MB),
             MB.getBufferIdentifier() + ": failed to parse archive");

Modified: lld/trunk/ELF/Driver.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.h?rev=301895&r1=301894&r2=301895&view=diff
==============================================================================
--- lld/trunk/ELF/Driver.h (original)
+++ lld/trunk/ELF/Driver.h Mon May  1 21:57:45 2017
@@ -31,7 +31,6 @@ public:
   void addLibrary(StringRef Name);
 
 private:
-  std::vector<MemoryBufferRef> getArchiveMembers(MemoryBufferRef MB);
   void readConfigs(llvm::opt::InputArgList &Args);
   void createFiles(llvm::opt::InputArgList &Args);
   void inferMachineType();




More information about the llvm-commits mailing list