[PATCH] D32536: Extend memcpy expansion in Transform/Utils to handle wider operand types.

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 19:52:08 PDT 2017


sfertile marked an inline comment as done.
sfertile added inline comments.


================
Comment at: lib/Transforms/Utils/LowerMemIntrinsics.cpp:465
+                                /* TargetTransformInfo */ TTI);
+    } else {
+      createMemCpyLoopUnknownSize(/* InsertBefore */ Memcpy,
----------------
jtony wrote:
> This is optional. Is it better to just call createMemCpyLoopKnownSize once and set the CopyLen  parameter using a ternary expression? So we can save a few lines of code.
I don't see how that would help, these are 2 different functions we are calling based on if the size argument is a constant or not.


Repository:
  rL LLVM

https://reviews.llvm.org/D32536





More information about the llvm-commits mailing list