[PATCH] D32536: Extend memcpy expansion in Transform/Utils to handle wider operand types.

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 11:58:16 PDT 2017


sfertile marked 6 inline comments as done.
sfertile added inline comments.


================
Comment at: lib/Transforms/Utils/LowerMemIntrinsics.cpp:186
+  Value *NewIndex =
+      LoopBuilder.CreateAdd(LoopIndex, ConstantInt::get(CopyLenType, 1));
+  LoopIndex->addIncoming(NewIndex, LoopBB);
----------------
jtony wrote:
> Why do we use 1 here and use 0U at line 203?
I'm not sure why I only added the suffix in one call. I've updated the other calls to use unsigned literals also.


Repository:
  rL LLVM

https://reviews.llvm.org/D32536





More information about the llvm-commits mailing list