[PATCH] D32618: DWARF: Implementation of v5 string offsets table (.debug_str_offsets[.dwo] section)

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added a comment.

Also, Dave would prefer to split the patch in 2, in producer/consumer. Any objections?



================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:80
+      CUNode(Node), Asm(A), DD(DW), DU(DWU), IndexTyDie(nullptr),
+      StringOffsetsStartSym(nullptr) {}
 
----------------
aprantl wrote:
> wolfgangp wrote:
> > aprantl wrote:
> > > = nullptr?
> > This symbol is not needed in v4 and earlier and only gets created when there is a string offsets section. Could you elaborate what your objection is?
> It looks like phabricator misleadingly interpreted my source code as formatting :-)
> this was meant to say: `= nullptr`, i.e., doing a C++11-style initialization in the header file might look better here?
Ah, OK, sure. I agree. I'll make that change.


https://reviews.llvm.org/D32618