[PATCH] D32618: DWARF: Implementation of v5 string offsets table (.debug_str_offsets[.dwo] section)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:80
+      CUNode(Node), Asm(A), DD(DW), DU(DWU), IndexTyDie(nullptr),
+      StringOffsetsStartSym(nullptr) {}
 
----------------
wolfgangp wrote:
> aprantl wrote:
> > = nullptr?
> This symbol is not needed in v4 and earlier and only gets created when there is a string offsets section. Could you elaborate what your objection is?
It looks like phabricator misleadingly interpreted my source code as formatting :-)
this was meant to say: `= nullptr`, i.e., doing a C++11-style initialization in the header file might look better here?


https://reviews.llvm.org/D32618