[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Martell Malone via Phabricator via llvm-commits]

martell added a comment.

In https://reviews.llvm.org/D32689#741964, @ruiu wrote:

> Since you are moving application code to a library, you want to make it more like library code. In particular, you want to avoid using global variables and `fatal()` function. Errors should be returned as return values of type Expected<T>.


This makes sense, my next step will be to remove the fatal exits and return Expected<T> or an Error.
Thanks for the feedback.

In https://reviews.llvm.org/D32689#741964, @ruiu wrote:

> Did you forget to include a header file for Librarian.cpp?


That was a file I removed, there was no header for Librarian, prototypes for the function lived in `tools/lld/COFF/Driver.h` 
This now lives between `COFFImportFile.h` and `COFFImportFile.cpp`


Repository:
  rL LLVM

https://reviews.llvm.org/D32689