[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Since you are moving application code to a library, you want to make it more like library code. In particular, you want to avoid using global variables and `fatal()` function. Errors should be returned as return values of type Expected<T>.

Did you forget to include a header file for Librarian.cpp?


Repository:
  rL LLVM

https://reviews.llvm.org/D32689