[llvm] r301722 - [LoopUnswitch] Don't remove instructions with side effects.
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 28 17:12:18 PDT 2017
Author: davide
Date: Fri Apr 28 19:12:18 2017
New Revision: 301722
URL: http://llvm.org/viewvc/llvm-project?rev=301722&view=rev
Log:
[LoopUnswitch] Don't remove instructions with side effects.
This fixes PR32818.
Differential Revision: https://reviews.llvm.org/D32664
Added:
llvm/trunk/test/Transforms/LoopUnswitch/pr32818.ll
Modified:
llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp
Modified: llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp?rev=301722&r1=301721&r2=301722&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp Fri Apr 28 19:12:18 2017
@@ -1275,7 +1275,8 @@ static void ReplaceUsesOfWith(Instructio
LPM->deleteSimpleAnalysisValue(I, L);
RemoveFromWorklist(I, Worklist);
I->replaceAllUsesWith(V);
- I->eraseFromParent();
+ if (!I->mayHaveSideEffects())
+ I->eraseFromParent();
++NumSimplify;
}
Added: llvm/trunk/test/Transforms/LoopUnswitch/pr32818.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopUnswitch/pr32818.ll?rev=301722&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/LoopUnswitch/pr32818.ll (added)
+++ llvm/trunk/test/Transforms/LoopUnswitch/pr32818.ll Fri Apr 28 19:12:18 2017
@@ -0,0 +1,19 @@
+; Check that the call doesn't get removed even if
+; it has no uses. It could have side-effects.
+; RUN: opt -loop-unswitch -S %s | FileCheck %s
+
+; CHECK-LABEL: @tinky
+define i32 @tinkywinky(i8 %patatino) {
+ %cmp1 = icmp slt i8 %patatino, 5
+ br label %body
+body:
+ %i = select i1 %cmp1, i8 6, i8 undef
+ br i1 true, label %body, label %end
+end:
+ %split = phi i8 [ %i, %body ]
+ %conv4 = sext i8 %split to i32
+; CHECK: tail call fastcc i32 @fn5(
+ %call = tail call fastcc i32 @fn5(i32 %conv4)
+ ret i32 0
+}
+declare fastcc i32 @fn5(i32 returned) unnamed_addr
More information about the llvm-commits
mailing list