[llvm] r301720 - [llvm-readobj] Fix incorrect printing of CV column info.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 17:03:33 PDT 2017


Author: zturner
Date: Fri Apr 28 19:03:32 2017
New Revision: 301720

URL: http://llvm.org/viewvc/llvm-project?rev=301720&view=rev
Log:
[llvm-readobj] Fix incorrect printing of CV column info.

Modified:
    llvm/trunk/tools/llvm-readobj/COFFDumper.cpp

Modified: llvm/trunk/tools/llvm-readobj/COFFDumper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp?rev=301720&r1=301719&r2=301720&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-readobj/COFFDumper.cpp (original)
+++ llvm/trunk/tools/llvm-readobj/COFFDumper.cpp Fri Apr 28 19:03:32 2017
@@ -906,6 +906,7 @@ void COFFDumper::printCodeViewSymbolSect
 
       ListScope S(W, "FilenameSegment");
       printFileNameForOffset("Filename", Entry.NameIndex);
+      uint32_t ColumnIndex = 0;
       for (const auto &Line : Entry.LineNumbers) {
         if (Line.Offset >= LineInfo.header()->CodeSize) {
           error(object_error::parse_failed);
@@ -925,8 +926,9 @@ void COFFDumper::printCodeViewSymbolSect
         W.printNumber("LineNumberEndDelta", LI.getLineDelta());
         W.printBoolean("IsStatement", LI.isStatement());
         if (LineInfo.header()->Flags & HaveColumns) {
-          W.printNumber("ColStart", Entry.Columns[0].StartColumn);
-          W.printNumber("ColEnd", Entry.Columns[0].EndColumn);
+          W.printNumber("ColStart", Entry.Columns[ColumnIndex].StartColumn);
+          W.printNumber("ColEnd", Entry.Columns[ColumnIndex].EndColumn);
+          ++ColumnIndex;
         }
       }
     }




More information about the llvm-commits mailing list