[PATCH] D32622: ARM: Compute MaxCallFrame size early

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added inline comments.


================
Comment at: lib/Target/ARM/ARMBaseRegisterInfo.cpp:253
+    bool HasFP = MF.getFrameInfo().isMaxCallFrameSizeComputed()
+                 ? TFI->hasFP(MF) : false;
+    return 5 - HasFP;
----------------
jmolloy wrote:
> Is it right that if we don't have accurate call frame information we assume FP is not used here? Shouldn't we default to the conservative "true"?
Yes until the end of instruction selection we assume FP is not used here. This only affects ScheduleDAGRRList. It should only be used to direct the DAG scheduling heuristic and not affect correctness. Anyway I don't see this making a difference one way or the other as the machine scheduler will reorder anyway.

So I'm fine either way, let's switch to `? TFI->hasFP(MF) : true;` then.


Repository:
  rL LLVM

https://reviews.llvm.org/D32622