[PATCH] D32622: ARM: Compute MaxCallFrame size early

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 00:28:59 PDT 2017


jmolloy added inline comments.


================
Comment at: lib/Target/ARM/ARMBaseRegisterInfo.cpp:253
+    bool HasFP = MF.getFrameInfo().isMaxCallFrameSizeComputed()
+                 ? TFI->hasFP(MF) : false;
+    return 5 - HasFP;
----------------
Is it right that if we don't have accurate call frame information we assume FP is not used here? Shouldn't we default to the conservative "true"?


Repository:
  rL LLVM

https://reviews.llvm.org/D32622





More information about the llvm-commits mailing list