[PATCH] D32491: [globalisel][tablegen] Compute available feature bits correctly.

[Diana Picus via llvm-commits]

Oh, derp, you're right. My tests are exercising the same
subtarget-level caching as the select-inc.mir (the target features are
specified in function attributes as opposed to being specified on the
command line, but it's the same thing). We still need the x86 optsize
test to work (or something equivalent to it).

On 28 April 2017 at 17:37, Daniel Sanders via Phabricator
<reviews at reviews.llvm.org> wrote:
> dsanders added a comment.
>
> In https://reviews.llvm.org/D32491#740829, @rovka wrote:
>
>> I just checked and the existing ARM tests fail without this patch because the available features aren't reset when entering the functions. They work with this patch + enabling the TableGen selector for ARM, so we'll have tests then :)
>
>
> Thanks.
>
> Before this patch the available features weren't computed at all (the code was never called) so just to double check. Are you checking tests that only need module-level predicates or do they include predicates that vary between functions? The former is covered by select-inc.mir, but the latter doesn't have a working test yet.
>
>
> https://reviews.llvm.org/D32491
>
>
>