[PATCH] D32491: [globalisel][tablegen] Compute available feature bits correctly.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 08:37:22 PDT 2017


dsanders added a comment.

In https://reviews.llvm.org/D32491#740829, @rovka wrote:

> I just checked and the existing ARM tests fail without this patch because the available features aren't reset when entering the functions. They work with this patch + enabling the TableGen selector for ARM, so we'll have tests then :)


Thanks.

Before this patch the available features weren't computed at all (the code was never called) so just to double check. Are you checking tests that only need module-level predicates or do they include predicates that vary between functions? The former is covered by select-inc.mir, but the latter doesn't have a working test yet.


https://reviews.llvm.org/D32491





More information about the llvm-commits mailing list