[PATCH] D32536: Extend memcpy expansion in Transform/Utils to handle wider operand types.
Zaara Syeda via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 28 08:39:42 PDT 2017
syzaara added inline comments.
================
Comment at: lib/Transforms/Utils/LowerMemIntrinsics.cpp:71
+ IRBuilder<> LoopBuilder(LoopBB);
+ PHINode *LoopIndex = LoopBuilder.CreatePHI(TypeOfCopyLen, 0, "loop-index");
+ LoopIndex->addIncoming(ConstantInt::get(TypeOfCopyLen, 0), PreLoopBB);
----------------
The second argument is a hint for the number of incoming edges that this phi node will have. It should be 2 in this case.
================
Comment at: lib/Transforms/Utils/LowerMemIntrinsics.cpp:177
+
+ PHINode *LoopIndex = LoopBuilder.CreatePHI(CopyLenType, 0, "loop-index");
+ LoopIndex->addIncoming(ConstantInt::get(CopyLenType, 0), PreLoopBB);
----------------
The second argument is a hint for the number of incoming edges that this phi node will have. It should be 2 in this case.
================
Comment at: lib/Transforms/Utils/LowerMemIntrinsics.cpp:220
+ PHINode *ResidualIndex =
+ ResBuilder.CreatePHI(CopyLenType, 0, "residual-loop-index");
+ ResidualIndex->addIncoming(Zero, ResHeaderBB);
----------------
Same note about second argument.
Repository:
rL LLVM
https://reviews.llvm.org/D32536
More information about the llvm-commits
mailing list