[PATCH] D32536: Extend memcpy expansion in Transform/Utils to handle wider operand types.

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: lib/Transforms/Utils/LowerMemIntrinsics.cpp:445
+  // Original implementation
+  if (!TTI.useWideIRMemcpyLoopLowering()) {
+    createMemCpyLoop(/* InsertBefore */ Memcpy,
----------------
arsenm wrote:
> I'm not sure this is a useful hook. If it's worth keeping the old path that had no target information, making TTI an optional pointer input and using it if available makes more sense
Sorry, I meant to explain how I broke this up in the description but forgot to. I added the new implementations but left them off by default. I've tested these with a PowerPC pass but I can't do any functional testing with the  current consumers since I don't have a gpu setup. The idea was that the current consumers can do functional testing between the 2 implementations easily if they want. Once any issues or concerns are addressed then I will add another patch (or update this one) to remove the option and the old implementation.


Repository:
  rL LLVM

https://reviews.llvm.org/D32536