[PATCH] D32569: [SelectionDAG] Use KnownBits struct in DAG's computeKnownBits and simplifyDemandedBits

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 01:20:47 PDT 2017


I didn't realize WebAssembly didn't build by default. I'll fix.

~Craig

On Fri, Apr 28, 2017 at 1:17 AM, Haojian Wu via Phabricator <
reviews at reviews.llvm.org> wrote:

> hokein added a comment.
>
> @craig.topper, your patch seems to break the WebAssembly builds:
>
>   In file included from ../lib/Target/WebAssembly/
> WebAssemblyISelDAGToDAG.cpp:63:0:
>   lib/Target/WebAssembly/WebAssemblyGenDAGISel.inc: In member function
> ‘virtual bool {anonymous}::WebAssemblyDAGToDAGISel::
> CheckNodePredicate(llvm::SDNode*, unsigned int) const’:
>   lib/Target/WebAssembly/WebAssemblyGenDAGISel.inc:5693:70: error: no
> matching function for call to ‘llvm::SelectionDAG::computeKnownBits(const
> llvm::SDValue&, llvm::APInt&, llvm::APInt&, int)’
>      CurDAG->computeKnownBits(N->getOperand(0), KnownZero0, KnownOne0, 0);
>                                                                         ^
>   lib/Target/WebAssembly/WebAssemblyGenDAGISel.inc:5693:70: note:
> candidates are:
>   In file included from ../include/llvm/Target/TargetLowering.h:35:0,
>                    from ../lib/Target/WebAssembly/
> WebAssemblyISelLowering.h:19,
>                    from ../lib/Target/WebAssembly/
> WebAssemblySubtarget.h:20,
>                    from ../lib/Target/WebAssembly/
> WebAssemblyTargetMachine.h:19,
>                    from ../lib/Target/WebAssembly/
> WebAssemblyISelDAGToDAG.cpp:17:
>   ../include/llvm/CodeGen/SelectionDAG.h:1291:8: note: void
> llvm::SelectionDAG::computeKnownBits(llvm::SDValue, llvm::KnownBits&,
> unsigned int) const
>      void computeKnownBits(SDValue Op, KnownBits &Known, unsigned Depth =
> 0) const;
>           ^
>   ../include/llvm/CodeGen/SelectionDAG.h:1291:8: note:   candidate
> expects 3 arguments, 4 provided
>   ../include/llvm/CodeGen/SelectionDAG.h:1298:8: note: void
> llvm::SelectionDAG::computeKnownBits(llvm::SDValue, llvm::KnownBits&,
> const llvm::APInt&, unsigned int) const
>      void computeKnownBits(SDValue Op, KnownBits &Known, const APInt
> &DemandedElts,
>           ^
>
> Can you take a look on it? Thanks.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32569
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170428/fded0ad4/attachment.html>


More information about the llvm-commits mailing list