<div dir="ltr">I didn't realize WebAssembly didn't build by default. I'll fix.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Fri, Apr 28, 2017 at 1:17 AM, Haojian Wu via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hokein added a comment.<br>
<br>
@craig.topper, your patch seems to break the WebAssembly builds:<br>
<br>
  In file included from ../lib/Target/WebAssembly/<wbr>WebAssemblyISelDAGToDAG.cpp:<wbr>63:0:<br>
  lib/Target/WebAssembly/<wbr>WebAssemblyGenDAGISel.inc: In member function ‘virtual bool {anonymous}::<wbr>WebAssemblyDAGToDAGISel::<wbr>CheckNodePredicate(llvm::<wbr>SDNode*, unsigned int) const’:<br>
  lib/Target/WebAssembly/<wbr>WebAssemblyGenDAGISel.inc:<wbr>5693:70: error: no matching function for call to ‘llvm::SelectionDAG::<wbr>computeKnownBits(const llvm::SDValue&, llvm::APInt&, llvm::APInt&, int)’<br>
     CurDAG->computeKnownBits(N-><wbr>getOperand(0), KnownZero0, KnownOne0, 0);<br>
                                                                        ^<br>
  lib/Target/WebAssembly/<wbr>WebAssemblyGenDAGISel.inc:<wbr>5693:70: note: candidates are:<br>
  In file included from ../include/llvm/Target/<wbr>TargetLowering.h:35:0,<br>
                   from ../lib/Target/WebAssembly/<wbr>WebAssemblyISelLowering.h:19,<br>
                   from ../lib/Target/WebAssembly/<wbr>WebAssemblySubtarget.h:20,<br>
                   from ../lib/Target/WebAssembly/<wbr>WebAssemblyTargetMachine.h:19,<br>
                   from ../lib/Target/WebAssembly/<wbr>WebAssemblyISelDAGToDAG.cpp:<wbr>17:<br>
  ../include/llvm/CodeGen/<wbr>SelectionDAG.h:1291:8: note: void llvm::SelectionDAG::<wbr>computeKnownBits(llvm::<wbr>SDValue, llvm::KnownBits&, unsigned int) const<br>
     void computeKnownBits(SDValue Op, KnownBits &Known, unsigned Depth = 0) const;<br>
          ^<br>
  ../include/llvm/CodeGen/<wbr>SelectionDAG.h:1291:8: note:   candidate expects 3 arguments, 4 provided<br>
  ../include/llvm/CodeGen/<wbr>SelectionDAG.h:1298:8: note: void llvm::SelectionDAG::<wbr>computeKnownBits(llvm::<wbr>SDValue, llvm::KnownBits&, const llvm::APInt&, unsigned int) const<br>
     void computeKnownBits(SDValue Op, KnownBits &Known, const APInt &DemandedElts,<br>
          ^<br>
<br>
Can you take a look on it? Thanks.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D32569" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D32569</a><br>
<br>
<br>
<br>
</blockquote></div><br></div>