[PATCH] D32245: Add an IR expansion pass for the experimental reductions

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: lib/CodeGen/ExpandReductions.cpp:96
+        continue;
+      Vec = II->getArgOperand(1);
+    case Intrinsic::experimental_vector_reduce_add:
----------------
RKSimon wrote:
> mkuper wrote:
> > Please annotate the fallthrough here. (And perhaps it would be better to rewrite this to avoid it)
> You've marked it as done by LLVM_FALLTHROUGH is still missing from these - you will get warnings on some buildbots
I might be misunderstanding what the "Done" means. I used it to mean I'll address this in the next patch when I upload it. I haven't got around to that yet.


Repository:
  rL LLVM

https://reviews.llvm.org/D32245