[PATCH] D32245: Add an IR expansion pass for the experimental reductions

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 06:35:32 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/ExpandReductions.cpp:96
+        continue;
+      Vec = II->getArgOperand(1);
+    case Intrinsic::experimental_vector_reduce_add:
----------------
mkuper wrote:
> Please annotate the fallthrough here. (And perhaps it would be better to rewrite this to avoid it)
You've marked it as done by LLVM_FALLTHROUGH is still missing from these - you will get warnings on some buildbots


Repository:
  rL LLVM

https://reviews.llvm.org/D32245





More information about the llvm-commits mailing list