[PATCH] D32039: PR31357 fix

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 08:58:16 PDT 2017


filcab added a comment.

I'd rather see this as 3 commits:

- `s/TLI.isOperationLegal/TLI.isOperationLegalOrCustom/`
- Refactor (name changes)
- Actual fix for PR31357



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3769
     return SDValue();
-  if (!TLI.isOperationLegal(ISD::BSWAP, VT))
+  if (!TLI.isOperationLegalOrCustom(ISD::BSWAP, VT))
     return SDValue();
----------------
This looks like a drive-by fix, can you split it?


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3962
     return SDValue();
-  if (!TLI.isOperationLegal(ISD::BSWAP, VT))
+  if (!TLI.isOperationLegalOrCustom(ISD::BSWAP, VT))
     return SDValue();
----------------
Same as above.


https://reviews.llvm.org/D32039





More information about the llvm-commits mailing list