[PATCH] D32039: PR31357 fix

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3895
 
-  unsigned Num;
+  unsigned mask;
   switch (N1C->getZExtValue()) {
----------------
RKSimon wrote:
> Style guide says variables should be Capitalized. It might be clearer to call it MaskByteOffset or similar. If possible this should be done as a separate NFC commit.
+1 to making this "MaskByteOffset" and doing that now as NFC, so this patch will be minimized. Also, make the change for Opc0 = N0.getOpcode() ahead of this patch. That should leave us with the actual functional changes.


https://reviews.llvm.org/D32039