[PATCH] D32330: X86: Don't emit zero-byte functions on Windows
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 21 14:10:38 PDT 2017
hans added inline comments.
================
Comment at: lib/Target/ARM/ARMInstrInfo.h:28
- /// getNoopForMachoTarget - Return the noop instruction to use for a noop.
- void getNoopForMachoTarget(MCInst &NopInst) const override;
+ /// getNoop - Return the noop instruction to use for a noop.
+ void getNoop(MCInst &NopInst) const override;
----------------
MatzeB wrote:
> Could have just removed the "getNoop -" part as we discourage that style nowadays.
Good point. Will do that when committing.
https://reviews.llvm.org/D32330
More information about the llvm-commits
mailing list