[PATCH] D32330: X86: Don't emit zero-byte functions on Windows
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 21 13:49:35 PDT 2017
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/Target/ARM/ARMInstrInfo.h:28
- /// getNoopForMachoTarget - Return the noop instruction to use for a noop.
- void getNoopForMachoTarget(MCInst &NopInst) const override;
+ /// getNoop - Return the noop instruction to use for a noop.
+ void getNoop(MCInst &NopInst) const override;
----------------
Could have just removed the "getNoop -" part as we discourage that style nowadays.
https://reviews.llvm.org/D32330
More information about the llvm-commits
mailing list