[PATCH] D32200: [LV] Refactor ILV.vectorize[Loop]() by introducing LVP.executePlan()

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 12:24:41 PDT 2017


mssimpso added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:395
+  /// Create a new empty loop. Unlink the old loop and connect the new one.
+  void createEmptyLoop();
+
----------------
mkuper wrote:
> The public interface this ends up exposing is pretty weird, but I don't have any good ideas.
> Matt, what do you think?
I see what you mean, but I also don't have any real suggestions. Something like LV.vectorizeLoop(LVP.getBestVPlan()) might be more straightforward than LVP.executePlan(). But I'm not sure how such a change would affect the refactoring plans.


https://reviews.llvm.org/D32200





More information about the llvm-commits mailing list