[PATCH] D32200: [LV] Refactor ILV.vectorize[Loop]() by introducing LVP.executePlan()
Michael Kuperstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 11:57:46 PDT 2017
mkuper added a reviewer: mssimpso.
mkuper added inline comments.
================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:395
+ /// Create a new empty loop. Unlink the old loop and connect the new one.
+ void createEmptyLoop();
+
----------------
The public interface this ends up exposing is pretty weird, but I don't have any good ideas.
Matt, what do you think?
================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:472
- /// A helper function to vectorize a single instruction within the innermost
- /// loop.
+public:
+ /// A function to vectorize a single instruction within the innermost loop.
----------------
Can you move this into the public part above, instead of adding one here?
https://reviews.llvm.org/D32200
More information about the llvm-commits
mailing list