[PATCH] D32282: [ARM] ACLE Chapter 9 support

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: include/clang/Basic/BuiltinsARM.def:52
+BUILTIN(__builtin_arm_uxtab16, "iii", "nc")
+BUILTIN(__builtin_arm_uxtb16, "ii", "nc")
+
----------------
Are test cases missing for this one and the 3 ones above?


================
Comment at: include/clang/Basic/BuiltinsARM.def:54
+
+BUILTIN(__builtin_arm_sel, "iii", "nc")
+
----------------
test case missing?


================
Comment at: include/clang/Basic/BuiltinsARM.def:67
+BUILTIN(__builtin_arm_uqsub8, "UiUiUi", "nc")
+BUILTIN(__builtin_arm_usub8, "UiUiUi", "nc")
+
----------------
test cases missing for all of these?


================
Comment at: include/clang/Basic/BuiltinsARM.def:71
+BUILTIN(__builtin_arm_usad8, "UiUiUi", "nc")
+BUILTIN(__builtin_arm_usada8, "UiUiUiUi", "nc")
+
----------------
test cases missing for these 2?


================
Comment at: lib/Headers/arm_acle.h:318
+#if __ARM_FEATURE_SIMD32
+#define __ssat16(x, y) __builtin_arm_ssat16(x, y)
+#define __usat16(x, y) __builtin_arm_usat16(x, y)
----------------
Do we need tests for this and the one below?


https://reviews.llvm.org/D32282