[PATCH] D32282: [ARM] ACLE Chapter 9 support
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 07:03:08 PDT 2017
SjoerdMeijer added a comment.
Ok, that makes sense, thanks for explaining! (would be good to mention this in the commit message).
I now started looking at the actual commit, and the first thing I noticed was:
BUILTIN(__builtin_arm_usat, "UiUiUi", "nc")
This looks wrong, the spec says:
uint32_t __usat(int32_t, /*constant*/ unsigned int);
And thus the tests also looks wrong to me. I appreciate this was not your contribution, but while you're at it....
https://reviews.llvm.org/D32282
More information about the llvm-commits
mailing list