[PATCH] D32202: [XRay][compiler-rt] Fix up CFI annotations and stack alignment

[Evgeniy Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

In https://reviews.llvm.org/D32202#730125, @dberris wrote:

> In https://reviews.llvm.org/D32202#730098, @dberris wrote:
>
> > In https://reviews.llvm.org/D32202#730089, @eugenis wrote:
> >
> > > FunctionEntry does not look right. It has the frame of 216 bytes (return address + rbp + 184), which is not a multiple of 16. The same with ArgLoggerEntry.
> >
> >
> > So adjusting this just another 8 bytes artificially would be fine, yes?
>
>
> Looked into this a bit more and because rbp + 184 + address is really just 208, we're fine (it's 16-byte aligned ).


I think we are both wrong: rbp + 184 + address is 200, and it's not 16-byte aligned.
Does it work because the instrumentation calls this trampoline with 16+8 aligned stack?


Repository:
  rL LLVM

https://reviews.llvm.org/D32202