[PATCH] D32202: [XRay][compiler-rt] Fix up CFI annotations and stack alignment

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S:66-68
 	.cfi_startproc
 	pushq %rbp
 	.cfi_def_cfa_offset 16
----------------
kpw wrote:
> Does Martin's comment explain this? Quadwords are 8 bytes on x86. Why is the offset 16 bytes here?
Yes, Martin's comment explains that as the function is entered, the offset is already at 8 because the 'call' instruction would have already put the return address onto the stack. So the push of 8 bytes would adjust the offset to 16.


Repository:
  rL LLVM

https://reviews.llvm.org/D32202