[PATCH] D32127: ARM: Use methods to access data stored with frame instructions

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 01:28:04 PDT 2017


jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.

One change requested, otherwise LGTM. Thanks for the cleanup!



================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.h:419
+      return MI.getOperand(2).getReg();
+    // Operands of ADJCALLSTACKUP:
+    // - argument declared in ADJCALLSTACKUP pattern:
----------------
Asserts are cheap: I'd prefer if you could assert that MI is ADJCALLSTACKUP here.


https://reviews.llvm.org/D32127





More information about the llvm-commits mailing list