[PATCH] D32023: [ProfileData] Support coverage for PE binaries

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/trunk/include/llvm/ProfileData/InstrProfData.inc:666
+
+#ifdef _WIN32
 /* Runtime section names and name strings.  */
----------------
rnk wrote:
> rnk wrote:
> > This ifdef breaks cross compiling. In particular, llvm/test/Instrumentation/InstrProfiling/X86/alloc.ll is failing on Windows since this change. LLVM should choose the section name at runtime based on the target triple, not the host defines.
> Oops, I think I spoke too soon. I don't think I understand why the test is failing yet.
Yeah, it's not the ifdef (sorry), it's the TODOs in llvm-cov that highlight all the points where cross-running llvm-cov on a binary with a different object format from the host will fail. I wrote https://reviews.llvm.org/D32090 to try to address that, but I'm open to other ideas.


Repository:
  rL LLVM

https://reviews.llvm.org/D32023