[PATCH] D32023: [ProfileData] Support coverage for PE binaries

[Xinliang David Li via llvm-commits]

On Fri, Apr 14, 2017 at 9:53 AM, Reid Kleckner via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> rnk added inline comments.
>
>
> ================
> Comment at: llvm/trunk/include/llvm/ProfileData/InstrProfData.inc:666
> +
> +#ifdef _WIN32
>  /* Runtime section names and name strings.  */
> ----------------
> rnk wrote:
> > This ifdef breaks cross compiling. In particular,
> llvm/test/Instrumentation/InstrProfiling/X86/alloc.ll is failing on
> Windows since this change. LLVM should choose the section name at runtime
> based on the target triple, not the host defines.
> Oops, I think I spoke too soon. I don't think I understand why the test is
> failing yet.
>
>
To clarify -- the ifdef is not used by compiler but only runtime, so it is
not the cause of the failure. That patch already enables compiler to check
target type and decide what name scheme to use. However, in target object
lowering code, the object format is not passed in thus the naming for the
host is returned -- it is a just a bug in the patch.

David


>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32023
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170414/41c10e39/attachment.html>