[PATCH] D31920: llvm-lto2: Add a dump-symtab subcommand.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with one suggestion below.



================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:297
+    outs() << "source filename: " << Input->getSourceFileName() << '\n';
+    outs() << "linker opts: " << Input->getCOFFLinkerOpts() << '\n';
+
----------------
pcc wrote:
> tejohnson wrote:
> > What if not COFF? Should this line be suppressed?
> It will just print the empty string (same for the fallback below). Not a big deal for now, but we can suppress it once we add the target triple to the irsymtab and the LTO API.
Can you add "(COFF only)" or something to the output string? I think it would be good to distinguish between COFF with no linker opts vs linker opts not available for this format.


https://reviews.llvm.org/D31920