[PATCH] D31920: llvm-lto2: Add a dump-symtab subcommand.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:297
+    outs() << "source filename: " << Input->getSourceFileName() << '\n';
+    outs() << "linker opts: " << Input->getCOFFLinkerOpts() << '\n';
+
----------------
tejohnson wrote:
> What if not COFF? Should this line be suppressed?
It will just print the empty string (same for the fallback below). Not a big deal for now, but we can suppress it once we add the target triple to the irsymtab and the LTO API.


================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:318
+      PrintBool('I', Sym.isIndirect());
+      PrintBool('M', Sym.canBeOmittedFromSymbolTable());
+      PrintBool('T', Sym.isTLS());
----------------
tejohnson wrote:
> Why 'M'? Maybe 'O' for Omitted?
Yes, I like 'O' better, done.


https://reviews.llvm.org/D31920