[PATCH] D31742: [Builtins] Fix lit test setup for Windows

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: test/builtins/Unit/lit.site.cfg.in:7
 config.target_arch = "@BUILTINS_TEST_TARGET_ARCH@"
-
+config.builtins_is_msvc = "@MSVC@"
 # Load common config for all compiler-rt lit tests.
----------------
This might become the strings "ON", "", or "OFF", I'm not sure which. I'd rather follow the example of SANITIZER_CAN_USE_CXXABI and use pythonize_bool(MSVC) in test/builtins/CMakeLists.txt and @MSVC_PYBOOL@ here.


https://reviews.llvm.org/D31742